Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore has tabs #4618

Closed
rkristelijn opened this issue Jan 20, 2025 · 3 comments · Fixed by #4622 · May be fixed by #4621
Closed

.gitignore has tabs #4618

rkristelijn opened this issue Jan 20, 2025 · 3 comments · Fixed by #4622 · May be fixed by #4621
Assignees
@bharatkashyap
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@rkristelijn
Copy link
Contributor

rkristelijn commented Jan 20, 2025 •
edited by github-actions bot
Loading

Steps to reproduce

Steps:

  1. npx create-toolpad-app@latest
  2. git init
  3. observe errors in git, node_modules not ignored

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: gitignore git tabs
@rkristelijn rkristelijn added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 20, 2025
@Janpot
Copy link
Member

Janpot commented Jan 20, 2025 •
edited
Loading

👍 .gitignore file shouldn't be indented. Would you be interested in contributing a fix?

@Janpot Janpot added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 20, 2025
@Janpot Janpot added the good first issue Great for first contributions. Enable to learn the contribution process. label Jan 20, 2025
@bharatkashyap bharatkashyap mentioned this issue Jan 20, 2025
Open
rkristelijn added a commit to rkristelijn/toolpad that referenced this issue Jan 20, 2025
@rkristelijn
fix: .gitignore has tabs Closes mui#4618
7fc57a1
@rkristelijn
Copy link
Contributor Author

Please find attached my pull request @Janpot

@bharatkashyap bharatkashyap mentioned this issue Jan 20, 2025
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@rkristelijn How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharatkashyap bharatkashyap

Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
3 participants
@Janpot @bharatkashyap @rkristelijn