React resizable panels #2398
Merged
React resizable panels #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
| @@ -152,8 +152,8 @@ test('must correctly size new layout columns', async ({ page }) => { | |||
| const secondFullWidthBoundingBox3 = await getNthFullWidthBoundingBox(1); | |||
| const thirdFullWidthBoundingBox3 = await getNthFullWidthBoundingBox(2); | |||
|
|
|||
| expect(firstFullWidthBoundingBox3!.width).toBe(secondFullWidthBoundingBox3!.width); | |||
There was a problem hiding this comment.
I think this is because of minor differences in the resize handler widths:
Sufficiently minor to ignore in my opinion
There was a problem hiding this comment.
I think that's fine if there's no easy better solution!
Janpot
commented
Aug 21, 2023
There was a problem hiding this comment.
@bharatkashyap Can't approve my own PR, but this looks good to me 👍 . Thanks for completing this work.
Let's keep an eye on bvaughn/react-resizable-panels#182 for the pixel based sizes
2 tasks
bharatkashyap
approved these changes
Aug 22, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-split-panewithreact-resizable-panelseverywhere in preparation for merging a bottom query panel UXScreen.Recording.2023-08-17.at.5.41.46.PM.mov
Also closes #2516