Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make routing page name based #2949

Merged
merged 15 commits into from
Dec 1, 2023
Merged

Make routing page name based #2949

merged 15 commits into from
Dec 1, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Nov 29, 2023

Remove the legacy "id" and route by page name instead.

To avoid breaking existing links, current ids are converted to a page alias, which redirects to the page name

mui/material-ui#40044 for docs yaml support

docs: https://deploy-preview-2949--mui-toolpad-docs.netlify.app/toolpad/concepts/page-properties/#page-alias

Closes #2498

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Nov 29, 2023
@Janpot Janpot marked this pull request as ready for review November 29, 2023 18:04
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2023
@Janpot Janpot merged commit 9c8208f into mui:master Dec 1, 2023
@Janpot Janpot deleted the remove-page-id branch December 1, 2023 11:07
@Janpot Janpot mentioned this pull request Feb 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant