Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove components from appDom #3017

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Remove components from appDom #3017

merged 5 commits into from
Dec 22, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 21, 2023

Manage components separately from the dom.

  • Solve ambiguities in the code on the flow between file system and what's in the runtime. Half of the flow was in the dom, half was out. This also caused too many updates of the editor when things in the project folder changes.
  • Move further towards isolating the dom as model for the pages
  • Fixed an issue along the way where the theme didn't update when it was changed manually on disk

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Dec 21, 2023
@Janpot Janpot mentioned this pull request Dec 21, 2023
@Janpot Janpot changed the title Remove components from dom Remove components from appDom Dec 21, 2023
@Janpot Janpot marked this pull request as ready for review December 21, 2023 17:26
@Janpot Janpot requested a review from a team December 21, 2023 17:27
@Janpot
Copy link
Member Author

Janpot commented Dec 21, 2023

@bharatkashyap the visual regression tests are flaky around the new query editor

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 21, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 21, 2023
@Janpot Janpot merged commit a030b03 into mui:master Dec 22, 2023
2 checks passed
@Janpot Janpot deleted the componnets branch December 22, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant