Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization docs #3067

Merged
merged 43 commits into from
Feb 5, 2024
Merged

Add authorization docs #3067

merged 43 commits into from
Feb 5, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Jan 9, 2024

Authorization docs. Can be iterated on.

Removes the feature flag for authentication/authorization too - I think we can fully release the feature by merging #3056 first and then this PR.

Previews:

@apedroferreira apedroferreira added the docs Improvements or additions to the documentation label Jan 9, 2024
@apedroferreira apedroferreira self-assigned this Jan 9, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 12, 2024
apedroferreira and others added 7 commits January 16, 2024 17:50
renovate bot and others added 6 commits January 18, 2024 23:06
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 18, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@apedroferreira apedroferreira marked this pull request as ready for review January 31, 2024 16:44
@apedroferreira apedroferreira requested a review from a team January 31, 2024 16:44

{{"component": "modules/components/DocsImage.tsx", "src": "/static/toolpad/docs/concepts/authorization/authentication-settings.png", "alt": "Authentication settings", "caption": "Authentication settings", "indent": 1, "aspectRatio": 6 }}

## Authentication secret
Copy link
Member

@Janpot Janpot Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a note here that it's important in production to keep this secret safe and not share it with anyone?


{{"component": "modules/components/DocsImage.tsx", "src": "/static/toolpad/docs/concepts/authorization/google-redirect-url.png", "alt": "Google redirect URIs configuration", "caption": "Google redirect URIs configuration", "zoom": false, "width": 460 }}

### Azure Active Directory (now Entra ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a warning here that it's only going to be available on a plan?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, I've added a few small warnings: dd63fe6

@apedroferreira apedroferreira requested a review from Janpot February 1, 2024 18:19
@apedroferreira apedroferreira merged commit e640765 into mui:master Feb 5, 2024
11 checks passed
@apedroferreira apedroferreira deleted the auth-docs branch February 5, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants