-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RBAC with Azure AD authentication provider #3077
Changes from 22 commits
973aa97
ba2399d
ebcbf55
08791c6
ef5731b
39c0f00
d7fc87c
07015a0
f730414
ebce000
60f031d
f58dcc9
43c9af0
1c06826
f6fdf95
761f0ed
71ea8a7
9cffb6a
8f150de
f550a02
f725a21
7d921c2
7020013
2075577
5d82afb
704feef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,7 +98,7 @@ | |
"engines": { | ||
"npm": "please-use-yarn", | ||
"node": ">=18", | ||
"pnpm": "8.7.0" | ||
"pnpm": ">=8.7.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this fine or should I use this specific version of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was hoping we could pin the pnpm version, just like we used to do with yarn There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So I should use 8.7.0? Why are we not using a more recent version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Because I haven't yet fully figured out yet how to enforce this in circleci, netlify, ánd codesandbox ci simultaneously. |
||
}, | ||
"resolutions": { | ||
"google-auth-library": "*" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import * as React from 'react'; | ||
|
||
interface AzureIconProps { | ||
size?: number; | ||
color?: string; | ||
} | ||
|
||
export default function AzureIcon({ size = 18, color = 'currentColor' }: AzureIconProps) { | ||
return ( | ||
<svg viewBox="0 0 59.242 47.271" width={size} height={size} xmlns="http://www.w3.org/2000/svg"> | ||
<path | ||
d="m32.368 0-17.468 15.145-14.9 26.75h13.437zm2.323 3.543-7.454 21.008 14.291 17.956-27.728 4.764h45.442z" | ||
fill={color} | ||
/> | ||
</svg> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitively this feels like a provider specific property. e.g. how would this work under Google/GitHub?
I'd sort of have expected something like:
Also, UI doesn't really have proirity right now. I'm fine to release this with config only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I'll make that change, seems better. The UI is already done so should be easy to keep now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the schema here: 2075577
The schema definition is much better like this too.