Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent app header from covering page elements #3220

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Feb 15, 2024

Stop header bar with authentication from covering page elements. I changed it from being transparent to a white background same as the sidebar, and made it take up the space of the header height.

Tried a few other things, but this seems like the best way for the header to work together with the existing sidebar - no border, dividers or shadows.

Screen.Recording.2024-02-15.at.23.45.11.mov

Closes #3212

@apedroferreira apedroferreira marked this pull request as ready for review February 15, 2024 23:51
@apedroferreira apedroferreira merged commit 14b6a6a into mui:master Feb 19, 2024
11 checks passed
@apedroferreira apedroferreira deleted the auth-header branch February 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For a logged in user, the avatar icon overlaps with the UI
2 participants