-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pnpm to 8.15.7 #3396
Bump pnpm to 8.15.7 #3396
Conversation
@@ -100,10 +100,10 @@ | |||
"engines": { | |||
"npm": "please-use-pnpm", | |||
"node": ">=18", | |||
"pnpm": "8.15.6" | |||
"pnpm": "8.15.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get we want to use https://pnpm.io/installation#using-corepack but do we need to have this here?
"pnpm": "8.15.7" |
Maybe with pnpm v9 we don't need this anymore: https://github.com/pnpm/pnpm/releases/tag/v9.0.0-rc.2
pnpm will now check the package.json file for a packageManager field. If this field is present and specifies a different package manager or a different version of pnpm than the one you're currently using, pnpm will not proceed. This ensures that you're always using the correct package manager and version that the project requires.
we would then match the other repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We enforce a specific version with the engines field. In case someone tries to install who is not using corepack, or an older (pre-corepack) pnpm version.
So:
- the
packageManager
field: makes sure the correct pnpm version is used when corepack is enabled - the
preinstall
script: makes sure when corepack is not enabled and an older version of e.g.yarn
is used - the engines field: makes sure the correct version of
pnpm
is used in case corepack is not enabled, and an older version ofpnpm
is used
Recent versions of yarn
and pnpm
should detect that corepack is intended and refuse to install. Older ones happily install and run scripts regardless. With v9, this field will still be necessary, for contributors that are not on v9 yet. We should port this to other reporitories (and the .npmrc
's engines-strict
option as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this makes sense.
I would wait to see that the next upgrades of pnpm go smoothly, and once they do go all-in to propagate this in all repositories mui/mui-public#157.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks like it does: #3499
For some reason codesandbox ci stopped using corepack? It's now failing because trying to run with the wrong version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to codesandbox, they have updated the platform to use corepack again.
This PR contains the following updates:
8.15.6
->8.15.7
Release Notes
pnpm/pnpm (pnpm)
v8.15.7
Compare Source
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.