Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bootstrap authentication from create-toolpad-app #3860

Merged
merged 54 commits into from
Aug 22, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Jul 28, 2024

Adds

  • Authentication prompt questions to create-toolpad-app
Screenshot 2024-07-28 at 7 32 15 PM

To Do

  • Bootstrap .env.local with empty secrets but valid keys
  • Handlenextjs-pages router branch

Questions

  • Instead of using strings to bootstrap files, create template folders for different scenarios and copy them based on user selection, instead of writing string content into files? This is what create-next-app does, and it seems to be more readable and maintanable.
    • Keep using strings for now; it might scale better versus creating separate folder for each permutation of initial selection, and plays better with the webcontainers demo

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 30, 2024
@bharatkashyap bharatkashyap added the create-toolpad-app Issues related to the `create-toolpad-app` CLI tool label Jul 30, 2024
@bharatkashyap bharatkashyap marked this pull request as ready for review August 1, 2024 13:24
@@ -0,0 +1,12 @@
export default `import * as React from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see us make each of those into a common shape like:

interface File {
  content: string
}

type Template = (option: Options) => File

That way a template has input, and can also return metadata beyond content

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2024
@bharatkashyap bharatkashyap merged commit 0fec340 into mui:master Aug 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI step for authentication
2 participants