-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Bootstrap authentication from create-toolpad-app
#3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 29, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 30, 2024
bharatkashyap
added
the
create-toolpad-app
Issues related to the `create-toolpad-app` CLI tool
label
Jul 30, 2024
Janpot
reviewed
Aug 1, 2024
@@ -0,0 +1,12 @@ | |||
export default `import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see us make each of those into a common shape like:
interface File {
content: string
}
type Template = (option: Options) => File
That way a template has input, and can also return metadata beyond content
Janpot
approved these changes
Aug 1, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 2, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 2, 2024
Janpot
reviewed
Aug 19, 2024
Janpot
reviewed
Aug 19, 2024
Janpot
reviewed
Aug 19, 2024
Janpot
reviewed
Aug 19, 2024
packages/create-toolpad-app/src/templates/nextjs-pages/indexPage.ts
Outdated
Show resolved
Hide resolved
Janpot
reviewed
Aug 19, 2024
Janpot
reviewed
Aug 19, 2024
packages/create-toolpad-app/src/templates/auth/nextjs-pages/signIn.ts
Outdated
Show resolved
Hide resolved
Janpot
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this
Janpot
reviewed
Aug 20, 2024
Janpot
reviewed
Aug 20, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 22, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 22, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 22, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
create-toolpad-app
To Do
.env.local
with empty secrets but valid keysnextjs-pages
router branchQuestions
create-next-app
does, and it seems to be more readable and maintanable.