[examples] Match Material UI v5 compatibility #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
approved these changes
Aug 8, 2024
Merged
github-actions
bot
added
the
PR: out-of-date
…-toolpad into fix/examples-v5-compat
github-actions
bot
removed
the
PR: out-of-date
Janpot
reviewed
Aug 9, 2024
| @@ -141,6 +141,12 @@ function SignInPage(props: SignInPageProps) { | |||
| ? (new URLSearchParams(window.location.search).get('callbackUrl') ?? '/') | |||
| : '/'; | |||
|
|
|||
| const [isClient, setIsClient] = React.useState(false); | |||
There was a problem hiding this comment.
The context should be there serverside.
Janpot
reviewed
Aug 9, 2024
packages/toolpad-core/package.json
Outdated
| @@ -39,7 +40,8 @@ | |||
| "scripts": { | |||
| "clean": "rimraf build", | |||
| "prebuild": "pnpm clean", | |||
| "build": "pnpm build:node && pnpm build:stable && pnpm build:types && pnpm build:copy-files", | |||
| "build": "pnpm build:node && pnpm build:stable && pnpm build:types && pnpm build:copy-files && pnpm esmify", | |||
| "esmify": "rm -rf ./build/node && rm -rf ./build/*/package.json", | |||
There was a problem hiding this comment.
Next.js resolver gets very confused about these @toolpad/core/*/package.json files. It loads CJS from pages/_app.tsx and ESM from pages/auth/signin.tsx. Forcing the package to be ESM-only solves all issues of double contexts being created.
At least this should unblock us. Will adapt the build script in core with a mode for esm only.
Janpot
reviewed
Aug 9, 2024
| typeof window !== 'undefined' | ||
| ? (new URLSearchParams(window.location.search).get('callbackUrl') ?? '/') | ||
| : '/'; | ||
| const router = React.useContext(RouterContext); |
Janpot
approved these changes
Aug 9, 2024
| @@ -49,6 +44,7 @@ export default function SignIn({ | |||
| return {}; | |||
| } catch (error) { | |||
| // An error boundary must exist to handle unknown errors | |||
| console.log('Is this happening'); | |||
There was a problem hiding this comment.
I think you missed this console log, just saw it :D
There was a problem hiding this comment.
I can remove it in the release PR.
There was a problem hiding this comment.
Missed that, thanks for catching @apedroferreira :)
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTH_GITHUB_IDtoGITHUB_CLIENT_IDin examples to matchcreate-toolpad-appbehaviourSignInPage