-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix layout shift example page #4350
[docs] Fix layout shift example page #4350
Conversation
I can see this still on the PR preview link: layoutShift.mov |
@bharatkashyap This is another issue, it's a problem with how docs-infra loads the font. Here the PR fixes the setState: Screen.Recording.2024-11-03.at.17.28.05.mov |
a435b2f
to
ff03ce9
Compare
e4e89e2
to
3260cad
Compare
7c57213
to
5a95ec6
Compare
5a95ec6
to
ef54edc
Compare
I have noticed problems with the repository spending a bit of time on this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. would maybe suggest to extract ${process.env.SOURCE_CODE_REPO}/tree/master
into its own variable and reuse between the conditional and the replace but not super important.
We have something equivalent in https://github.com/mui/material-ui/blob/060c55cb219bfc33633f7e61484884ea6d37bfdf/packages/markdown/parseMarkdown.js#L403 for the markdown. We might need to merge those two logics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Open https://mui.com/toolpad/core/introduction/examples/, see the paint flash / layout shift of the footer. An issue from #3383.
I noticed this on #4344.
After: https://deploy-preview-4350--mui-toolpad-docs.netlify.app/toolpad/core/introduction/examples/