[feature] add form decoding #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muir
force-pushed
the
formDecode
branch
2 times, most recently
from
b92f0cf to
403c51a
Compare
suqin-haha
reviewed
Oct 26, 2024
| @@ -195,7 +196,9 @@ var deepObjectRE = regexp.MustCompile(`^([^\[]+)\[([^\]]+)\]$`) // id[name] | |||
| // allowReserved=false # default | |||
| // allowReserved=true # query parameters only | |||
| // form=false # default | |||
| // form=true # cookies only | |||
| // form=true # query paramters only, may extract value from application/x-www-form-urlencoded POST content | |||
There was a problem hiding this comment.
add that if confilict, data from POST content will have higher precidence? and maybe add a test example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
formannotation didn't previously do anything.It now does. On
queryparameters, if you sayformorformOnlythen if the body isapplication/x-www-form-urlencodedthen it will decode the body and fill in the parameters from the body.If
formOnlyis used, than that parameter will only come from the body and will not come from the query string.This is somewhat backwards incompatible because previously
formwas defined but it didn't do anything.