Migrate old uninstall registry key #2023
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dlon)
dist-assets/windows/installer.nsh, line 602 at r1 (raw file):
Pop $0 # Migrate 2020.5 to current
Any info on the exact range of versions?
dist-assets/windows/installer.nsh, line 603 at r1 (raw file):
# Migrate 2020.5 to current registry::MoveKey "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{2A356FD4-03B7-4F45-99B4-737BE580DC82}" "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\${APP_GUID}"
Is the GUID being migrated from the same as APP_GUID? Should it still be expanded like that?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @mvd-ows)
dist-assets/windows/installer.nsh, line 602 at r1 (raw file):
Previously, mvd-ows wrote…
Any info on the exact range of versions?
Done.
dist-assets/windows/installer.nsh, line 603 at r1 (raw file):
Previously, mvd-ows wrote…
Is the GUID being migrated from the same as
APP_GUID? Should it still be expanded like that?
Done. The reason I expanded it is in case it is ever changed. But in that case, this stuff needs updates regardless.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
electron-builder recently reverted where the NSIS install/uninstall information is stored. This causes upgrades from version 2020.5 of the app to fail.
As was done before, this PR simply moves the registry key in
customInitto its new path, fixing upgrades from older versions. This does break downgrades, though. The app has to be fully uninstalled before an older version can be installed.This change is