Fix cleanup in build-windows-modules.sh for release builds
#7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
fix-win-modules-release-clean
branch
from
230d87f to
a7d560e
Compare
MarkusPettersson98
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
🪟 🔨
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
dlon
force-pushed
the
fix-win-modules-release-clean
branch
from
a7d560e to
683aefa
Compare
dlon
requested review from
faern,
raksooo,
pinkisemils and
albin-mullvad
as code owners
dlon
dismissed
MarkusPettersson98’s stale review
The base branch was changed.
MarkusPettersson98
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Reviewable status:
dlon
force-pushed
the
fix-win-modules-release-clean
branch
from
683aefa to
cd04223
Compare
MarkusPettersson98
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
dlon
force-pushed
the
fix-win-modules-release-clean
branch
from
8f8d013 to
3068d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is