Backport "Remove wait for tunnel up" to prepare-android/2025.1
#7617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
changed the title
prepare-android/2025.1
Rawa
force-pushed
the
remove-wait-for-tunnel-up
branch
from
7ca27fd to
c10bffe
Compare
Rawa
requested review from
faern,
raksooo,
pinkisemils and
albin-mullvad
as code owners
MarkusPettersson98
force-pushed
the
remove-wait-for-tunnel-up
branch
from
c10bffe to
2192872
Compare
After invoking VpnService.establish() we will get a tunnel file descriptor that corresponds to the interface that was created. However, this has no guarantee of the routing table beeing up to date, and we might thus send traffic outside the tunnel. Previously this was done through looking at the tunFd to see that traffic is sent to verify that the routing table has changed. If no traffic is seen some traffic is induced to a random IP address to ensure traffic can be seen. This new implementation is slower but won't risk sending UDP traffic to a random public address at the internet.
MarkusPettersson98
force-pushed
the
remove-wait-for-tunnel-up
branch
from
2192872 to
00b08c8
Compare
Rawa
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #7458 to the
2025.1android release branch.This change is