Fix race condition for whandshake #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See race condition reported at ipfs/kubo#4105 Reuse `whlock` for `whandshake`
Kubuxu
reviewed
Jul 29, 2017
| @@ -119,6 +119,9 @@ func (l *lazyConn) writeHandshake() error { | |||
| } | |||
|
|
|||
| func (l *lazyConn) Write(b []byte) (int, error) { | |||
| l.whlock.Lock() | |||
| defer l.whlock.Unlock() | |||
There was a problem hiding this comment.
This won't work as writeHandshake takes the same lock.
There was a problem hiding this comment.
My bad. I've removed the lock in writeHandshake and added it when calling it in Read.
|
I will dig into that concurrency here to make sure it is correct. I hope you won't mind if I come up with alternate solution. |
|
No problem @Kubuxu. Thanks for looking into it 👍 |
|
Fix in #21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See race condition reported at ipfs/kubo#4105
Reuse
whlockforwhandshake