This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
refactor: base32 encode CIDs by default #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `toString` and `toBaseEncodedString` will now use base32 encoding to encode version 1 CIDs by default. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
vmx
suggested changes
Jan 24, 2019
| @@ -110,7 +110,7 @@ describe('CID', () => { | |||
| expect(cid).to.have.property('version', 1) | |||
| expect(cid).to.have.property('multihash') | |||
|
|
|||
| expect(cid.toBaseEncodedString()).to.be.eql(cidStr) | |||
| expect(cid.toBaseEncodedString('base58btc')).to.be.eql(cidStr) | |||
There was a problem hiding this comment.
Please change the expect to use no base parameter, else the test doesn't match its description and is the same test as the one above.
|
Of course - there's absolutely no rush right now on getting this merged and released - I'll ping here when ready. |
|
Good to know. Without any context I was under the impression it's one of those "last missing pieces" :) |
Closed
1 task
This was referenced Feb 28, 2019
|
No longer required - v1 CIDs already switched to using base32 encoding by default. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
toStringandtoBaseEncodedStringwill now use base32 encoding to encode version 1 CIDs by default.