fix: Rewrite to interpret multiaddr from right to left #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will fail until multiformats/js-multiaddr#312 is merged |
achingbrain
changed the title
achingbrain
requested changes
Mar 17, 2023
No, they don't use this library. |
achingbrain
approved these changes
May 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 19, 2023
## [9.0.5](v9.0.4...v9.0.5) (2023-05-19) ### Bug Fixes * Rewrite to interpret multiaddr from right to left ([#120](#120)) ([681d4e3](681d4e3))
|
🎉 This PR is included in version 9.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to support
/tls/ws,/tls/http, and/tls/sni/example.com/http. Unfortunately the existing code interprets these multiaddrs left to right in a reduce loop. These multiaddrs (and multiaddrs in general) need to be parsed right to left. This refactors the code to so that it is interpreted right to left.It's a bit verbose, but straightforward.
This is somewhat blocked on multiformats/js-multiaddr#312 (Not strictly blocked, but would be good to bump the dep when that is merged).
This is needed because js-libp2p-websockets uses this library, and without this we can't dial addresses that use
/tls/wsor/tls/sni/example.com/ws...