This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
feat: add ts types #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
force-pushed
the
feat/ts-types
branch
from
d8266ec to
d8eaa89
Compare
Gozala
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Mostly nits & suggestions. Only thing I do feel strongly about is type names that I think should be singular instead of plural.
I also flagged out few things with
With type names changed 👍from me and no need for another review cycle.
| @@ -72,55 +57,6 @@ console.log(decodedBytes.toString()) | |||
| ## API | |||
| https://multiformats.github.io/js-multibase/ | |||
There was a problem hiding this comment.
💭 Maybe we do not need the whole section just for the link ?
There was a problem hiding this comment.
I don’t know maybe API Docs badge at the top ?
Gozala
approved these changes
Nov 19, 2020
achingbrain
approved these changes
Nov 20, 2020
Co-authored-by: Irakli Gozalishvili <[email protected]>
hugomrdias
force-pushed
the
feat/ts-types
branch
from
c748d31 to
280b133
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs ipfs/aegir#671
closes #54
closes #29
check published docs https://multiformats.github.io/js-multibase