Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Multihashing.functions is missing dbl-sha2-256 #25

Closed
vmx opened this issue Feb 26, 2018 · 3 comments
Closed

Multihashing.functions is missing dbl-sha2-256 #25

vmx opened this issue Feb 26, 2018 · 3 comments
Assignees
@vmx

Comments

@vmx
Copy link
Member

vmx commented Feb 26, 2018

js-multihashing-async has its own set of functions that need to be updated if a new hash algorithm is added. For Bitcoin/Zcash support dbl-sha2-256 was added. That one needs to be added.
@vmx vmx self-assigned this Feb 26, 2018
@vmx vmx mentioned this issue Feb 26, 2018
Closed
@daviddias
Copy link
Member

@vmx did you use multihashing for those two modules instead of multihashing-async?

@vmx
Copy link
Member Author

vmx commented Feb 27, 2018

Yes, I've used multihash (https://github.com/multiformats/js-multihash) for ipld-bitcoin and ipld-zcash.

@vmx
Copy link
Member Author

vmx commented Feb 27, 2018

@diasdavid: now I get what you mean. I've used hash.js directly. I guess I should use js-multihashing-async instead.

vmx added a commit that referenced this issue Feb 27, 2018
@vmx
feat: add double SHA2-256 hashing
ca49cd9 
The double SHA2-256 is e.g. used for Bitcoin and Zcash.

Fixes #25.
@vmx vmx mentioned this issue Feb 27, 2018
Merged
daviddias pushed a commit that referenced this issue Feb 27, 2018
@vmx @daviddias
feat: add double SHA2-256 hashing
cb3779d 
The double SHA2-256 is e.g. used for Bitcoin and Zcash.

Fixes #25.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vmx vmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmx @daviddias