-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/lib: Add Multiaddr::protocol_stack #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up!
Can you include a CHANGELOG.md
entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help here!
Can you address the CI failures @John-LittleBearLabs?
|
…addr into protostak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up. One more step needed. Again, sorry for the inconvenience.
CHANGELOG.md
Outdated
@@ -7,6 +7,8 @@ | |||
|
|||
- Use `multibase` instead of `bs58` for base58 encoding. See [PR 56]. | |||
|
|||
- Create `protocol_stack` for Multiaddr. See [PR 60] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiaddr
v0.15.0
just released, thus this needs to be moved to a new section for v0.16.0
and the Cargo.toml
in this project needs to be bumped.
Sorry for the inconvenience @John-LittleBearLabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @John-LittleBearLabs!
A convenience for cases where which protocols is of concern but the specific addresses are not, for example libp2p/rust-libp2p#2758