Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make /p2p type-safe #83

Merged
merged 9 commits into from
Jun 7, 2023
Merged

feat!: make /p2p type-safe #83

merged 9 commits into from
Jun 7, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Mar 22, 2023 •
edited
Loading

With the latest releases of multihash and libp2p-identity, we can now make the /p2p protocol of Multiaddr type-safe.

Resolves #73.
Resolves #91.

@thomaseizinger thomaseizinger mentioned this pull request Mar 22, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger changed the title feat: make /p2p type-safe feat!: make /p2p type-safe Mar 22, 2023
@mxinden
Copy link
Member

mxinden commented Mar 23, 2023

Release libp2p-identity 0.2.0 from the above branch without merging.

As discussed out-of-band I suggest merging into master and then releasing, thus the git tag is on a commit on master. Otherwise strategy looks good to me.

@thomaseizinger thomaseizinger mentioned this pull request May 2, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger modified the milestone: v0.18 May 5, 2023
@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented May 5, 2023 •
edited
Loading

To continue on this, we need to (in this order):

  1. Release rust-multihash v0.19
  2. Update feat: remove multiaddr dependency from libp2p-identity libp2p/rust-libp2p#3656 and merge it.
  3. Release libp2p-identity 0.2.0
  4. Update rust-multiaddr to libp2p-identity 0.2.0
  5. Merge this PR

mxinden
mxinden reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me thus far. Thanks.

@thomaseizinger thomaseizinger marked this pull request as ready for review June 6, 2023 17:36
@thomaseizinger thomaseizinger requested review from mxinden and vmx June 6, 2023 17:40
This was referenced Jun 6, 2023
Merged
Closed
@mxinden mxinden merged commit bdd6607 into multiformats:master Jun 7, 2023
mergify bot pushed a commit to libp2p/rust-libp2p that referenced this pull request Jun 8, 2023
@thomaseizinger
feat: leverage type-safe /p2p in multiaddr
ed14630 
This updates `multiaddr` to version `0.19`.

Depends-On: #3656.
Depends-On: multiformats/rust-multiaddr#83.
Resolves: #4039.

Pull-Request: #4037.
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@thomaseizinger
feat: leverage type-safe /p2p in multiaddr
805da8b 
This updates `multiaddr` to version `0.19`.

Depends-On: libp2p#3656.
Depends-On: multiformats/rust-multiaddr#83.
Resolves: libp2p#4039.

Pull-Request: libp2p#4037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@vmx vmx Awaiting requested review from vmx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to multihash v0.19 Making the /p2p protocol type-safe
2 participants
@thomaseizinger @mxinden