Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving whole site by fixing some issues #78

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Improving whole site by fixing some issues #78

merged 4 commits into from
Aug 8, 2023

Conversation

ben221199
Copy link
Contributor

This pull request fixes some problems, like:

  • Disappearing pages (see Web site multiaddr link failed #77)
  • Disappearing projects using Multiformats
  • Removing outdated dependencies, eventually replacing them with alternatives.
  • Improving some title properties.
  • Improving sitemap.xml
  • Adding robots.txt and adding sitemap to it.

This was referenced Jul 29, 2023
Open
Closed
rvagg
rvagg reviewed Aug 7, 2023
View reviewed changes
layouts/partials/header.html Outdated Show resolved Hide resolved
rvagg
rvagg reviewed Aug 7, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Aug 7, 2023

this is really nice, thanks @ben221199; just a couple of items I've commented on inline

@ben221199
Copy link
Contributor Author

Thanks for reviewing @rvagg. I will give a look at them.

@ben221199 ben221199 requested a review from rvagg August 7, 2023 08:41
@ben221199
Copy link
Contributor Author

I improved the code. The logo now works.

rvagg
rvagg approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thanks for the work here; it's a shame about the base_url, but perhaps someone can come up with something more robust later

@rvagg rvagg merged commit 49ad15a into multiformats:master Aug 8, 2023
@ben221199
Copy link
Contributor Author

Yeah, that base_url was some quick fix to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben221199 @rvagg