Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: coverage: back to Ubuntu 22.04 #317

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

matttbe
Copy link
Member

@matttbe matttbe commented Jan 27, 2025

'ubuntu-latest' is now following Ubuntu 24.04, which comes with LCOV 2.0.

That's great, but the autoconf-archive package in Ubuntu 24.04 doesn't support LCOV 2.0, a fix [1] is missing.

The simple solution not to block further development is to switch back to Ubuntu 22.04 for this workflow.

Link: https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commit;h=fc10ebf6185441fcd5e0c0a183fcb97497553594 [1]

'ubuntu-latest' is now following Ubuntu 24.04, which comes with LCOV
2.0.

That's great, but the autoconf-archive package in Ubuntu 24.04 doesn't
support LCOV 2.0, a fix [1] is missing.

The simple solution not to block further development is to switch back
to Ubuntu 22.04 for this workflow.

Link: https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commit;h=fc10ebf6185441fcd5e0c0a183fcb97497553594 [1]
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
@matttbe
Copy link
Member Author

matttbe commented Jan 27, 2025

I suggest merging this PR now, not to block new development. A better solution can be implemented later on, no urgency here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12993537357

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.075%

Totals Coverage Status
Change from base Build 11930597849: 0.0%
Covered Lines: 1409
Relevant Lines: 2199

💛 - Coveralls

@matttbe matttbe merged commit 07d4ec0 into multipath-tcp:main Jan 27, 2025
6 checks passed
@matttbe matttbe deleted the gha-coverage-22.04 branch January 27, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants