Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neo4j support #219

Merged
merged 8 commits into from
Apr 12, 2022
Merged

Add Neo4j support #219

merged 8 commits into from
Apr 12, 2022

Conversation

Posrabi
Copy link
Contributor

@Posrabi Posrabi commented Apr 11, 2022

  • Added support for Neo4j as a new graph database.

runner/database.go Outdated Show resolved Hide resolved
runner/database_neo4j.go Outdated Show resolved Hide resolved
@eatonphil
Copy link
Member

Really nice work overall! Were you able to test this out inside of the DataStation UI?

@Posrabi
Copy link
Contributor Author

Posrabi commented Apr 11, 2022

Really nice work overall! Were you able to test this out inside of the DataStation UI?

Yeah, everything work as expected

@eatonphil
Copy link
Member

You should also add a test to https://github.com/multiprocessio/datastation/blob/main/desktop/panel/database.test.js#L680. Feel free to copy the Prometheus tests and just change the parts to Neo4j.

You can test this with

yarn test-local desktop/panel/database.test.js -t 'neo4j'

Line 694 is the query panel.content = 'up'. So you'll replace up with your own query.

Second step: after that you'll also have to add steps to https://github.com/multiprocessio/datastation/blob/main/scripts/ci/prepare_linux_integration_test_setup_only.sh to turn on a neo4j docker container and load it with some data for this test. Look at how influx or prometheus are set up there.

But you can skip that second step while you're working on the test locally.

@Posrabi Posrabi changed the title Added Neo4j support Add Neo4j support Apr 12, 2022
Copy link
Member

@eatonphil eatonphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@eatonphil eatonphil merged commit bcbd1c3 into multiprocessio:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants