-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Neo4j support #219
Add Neo4j support #219
Conversation
Posrabi
commented
Apr 11, 2022
- Added support for Neo4j as a new graph database.
Really nice work overall! Were you able to test this out inside of the DataStation UI? |
Yeah, everything work as expected |
You should also add a test to https://github.com/multiprocessio/datastation/blob/main/desktop/panel/database.test.js#L680. Feel free to copy the Prometheus tests and just change the parts to Neo4j. You can test this with
Line 694 is the query Second step: after that you'll also have to add steps to https://github.com/multiprocessio/datastation/blob/main/scripts/ci/prepare_linux_integration_test_setup_only.sh to turn on a neo4j docker container and load it with some data for this test. Look at how influx or prometheus are set up there. But you can skip that second step while you're working on the test locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!