Add createBuilding for server #3897
Conversation
| @@ -129,8 +129,12 @@ class CClientGame | |||
| SCRIPTFILE, | |||
| WATER, | |||
| WEAPON, | |||
| POINTLIGHTS, | |||
| _DATABASE_CONNECTION, // server only | |||
There was a problem hiding this comment.
Why not DATABASE_CONNECTION?
There was a problem hiding this comment.
Because it's server only and unexpected on the client.
| POINTLIGHTS, | ||
| _DATABASE_CONNECTION, // server only | ||
| TRAIN_TRACK, | ||
| ROOT, |
There was a problem hiding this comment.
Synced with the server.
| case CCLIENTBUILDING: | ||
| { | ||
| CClientBuilding* pBuilding = static_cast<CClientBuilding*>(pSource); | ||
| const unsigned short usCurrentModel = pBuilding->GetModel(); |
There was a problem hiding this comment.
auto or std::uint16_t
currentModel instead of usCurrentModel?
building instead of pBuilding?
| CClientBuilding* pBuilding = static_cast<CClientBuilding*>(pSource); | ||
| const unsigned short usCurrentModel = pBuilding->GetModel(); | ||
|
|
||
| if (usCurrentModel != usModel) |
There was a problem hiding this comment.
It's ok with one break at the end of the block.
| CBuildingListType::const_iterator IterBegin() const { return m_List.begin(); }; | ||
| CBuildingListType::const_iterator IterEnd() const { return m_List.end(); }; |
There was a problem hiding this comment.
begin() and end()
const noexcept
useless trailing ;
There was a problem hiding this comment.
It should share the same interface with another managers. It's useful for lambda functions
There was a problem hiding this comment.
It should share the same interface with another managers.
Understandable. Please make at least a begin and end methods for standard range based loop
It's useful for lambda functions
Not really since for range loops exist
| @@ -82,6 +82,8 @@ class CElement | |||
| TRAIN_TRACK, | |||
| ROOT, | |||
| UNKNOWN, | |||
| BUILDING, | |||
| _POINTLIGHTS, // client only | |||
…te_building_server
Closes #3716
Test resource: building_serverside.zip