Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward checkSignature param for tx simulation #1422

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • when forwarding the /transaction/simulate endoint to gateway, the checkSignature query param was not forwarded

Proposed Changes

  • pass the query param as well

How to test

curl --request POST \
  --url http://localhost:3001/transaction/simulate \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/10.2.0' \
  --data '{
  "nonce":0,
  "value":"0",
  "receiver":"erd1qqqqqqqqqqqqqpgqccmyzj9sade2495w78h42erfrw7qmqxpd8sss6gmgn",
  "sender":"erd1qyu5wthldzr8wx5c9ucg8kjagg0jfs53s8nr3zpz3hypefsdd8ssycr6th",
  "senderUsername":"",
  "receiverUsername":"",
  "gasPrice":1000000000,
  "gasLimit":5000000,
  "data":"YWRkQDA3",
  "chainID":"D",
  "version":2,
  "options":0,
  "guardian":"",
  "signature":"5f9f8ede6c993944095ffa9c4356ccbbafc0a2d98df2fff93ad9e000366e42af332a8c907d93fe43f22f5b4763b408152bb3fb6a454c73473c86a509f011ba0f",
  "guardianSignature":"",
  "relayer":"",
  "relayerSignature": ""
}'

@bogdan-rosianu bogdan-rosianu self-assigned this Dec 11, 2024
Copy link

k6 load testing comparison.
Base Commit Hash: ddd5805
Target Commit Hash: 2ce86d9

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex46.33398.4849.9851.3745.82358.5349.7951.23-1.10% ✅-10.03% ✅-0.37% ✅-0.26% ✅
Blocks52.421313.8850.4552.8852.731007.1850.1351.86+0.60% 🔴-23.34% ✅-0.63% ✅-1.93% ✅
Nodes47.331222.2250.0351.3946.891171.5449.8251.18-0.95% ✅-4.15% ✅-0.43% ✅-0.42% ✅
Pool46.58663.3450.0251.4445.97396.1749.7851.22-1.31% ✅-40.28% ✅-0.48% ✅-0.42% ✅
Tokens46.61651.3350.0151.4246.15552.5149.8451.25-0.97% ✅-15.17% ✅-0.34% ✅-0.33% ✅
Transactions61.013506.7350.5552.6460.483403.5050.4852.99-0.87% ✅-2.94% ✅-0.13% ✅+0.68% 🔴
Accounts47.08916.1750.0651.5346.831038.2949.7551.27-0.53% ✅+13.33% 🔴-0.63% ✅-0.51% ✅
Test Run Duration60002.7160002.50

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu merged commit 5c112f4 into development Dec 11, 2024
5 checks passed
@bogdan-rosianu bogdan-rosianu deleted the add-check-signature-field-tx-simulate branch December 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants