Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor GetProof func and add some missing unit tests #6734

Open
wants to merge 2 commits into
base: feat/trie-mutex-refactor
Choose a base branch
from

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • Fix some TODOs

Proposed changes

  • Refactor GetProof() trie method to avoid a duplicated encode operation
  • Add unit tests for the trie rootManager

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants