Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feat/next into main #471

Merged
merged 25 commits into from
Aug 12, 2024
Merged

Merge feat/next into main #471

merged 25 commits into from
Aug 12, 2024

Conversation

popenta
Copy link
Contributor

@popenta popenta commented Aug 12, 2024

No description provided.

popenta and others added 25 commits June 6, 2024 15:34
Added amount parameter for unjailing transactions
Added RelayedV3 method in RelayedTransactionsFactory
Added methods for dynamic nfts
@popenta popenta self-assigned this Aug 12, 2024
Comment on lines +70 to +77
this.gasLimitEsdtModifyRoyalties = 60000000n;
this.gasLimitEsdtModifyCreator = 60000000n;
this.gasLimitEsdtMetadataUpdate = 60000000n;
this.gasLimitSetNewUris = 60000000n;
this.gasLimitNftMetadataRecreate = 60000000n;
this.gasLimitNftChangeToDynamic = 60000000n;
this.gasLimitUpdateTokenId = 60000000n;
this.gasLimitRegisterDynamic = 60000000n;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking only in theory. In practice, in this exact context, this is perfectly fine.

@@ -220,6 +221,7 @@ export class DelegationTransactionsFactory {
dataParts: dataParts,
gasLimit: this.computeExecutionGasLimitForNodesManagement(numNodes),
addDataMovementGas: true,
amount: options.amount,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing change 👍

@popenta popenta merged commit 062fb64 into main Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants