called setAddress on ledger login #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianMarian
previously approved these changes
Aug 10, 2021
ccorcoveanu
requested changes
Aug 10, 2021
|
@bogdan-rosianu The unreleased section is badly formatted. I know it's not your PR that affected this, but can we do it here so we won't end up merging it like this? |
ccorcoveanu
previously approved these changes
Aug 18, 2021
ccorcoveanu
approved these changes
Aug 18, 2021
SebastianMarian
approved these changes
Aug 18, 2021
danielailie
pushed a commit
that referenced
this pull request
Oct 2, 2024
Add support for custom HRP
danielailie
pushed a commit
that referenced
this pull request
Oct 2, 2024
Add support for custom HRP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called
setAddresswhen logging with Ledger with the specified index.Also, removed
addressIndexfrom the constructor