Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rolling update deadlock. #23

Merged
merged 1 commit into from
Jan 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions cmd/manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"github.com/mumoshu/aws-secret-operator/pkg/controller"
"github.com/operator-framework/operator-sdk/pkg/k8sutil"
"github.com/operator-framework/operator-sdk/pkg/leader"
"github.com/operator-framework/operator-sdk/pkg/ready"
sdkVersion "github.com/operator-framework/operator-sdk/version"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"sigs.k8s.io/controller-runtime/pkg/client/config"
Expand Down Expand Up @@ -54,13 +53,6 @@ func run() error {
// Become the leader before proceeding
leader.Become(context.TODO(), "aws-secret-operator-lock")

r := ready.NewFileReady()
err = r.Set()
if err != nil {
return errors.Wrap(err, "failed to set")
}
defer r.Unset()

// Create a new Cmd to provide shared dependencies and start components
mgr, err := manager.New(cfg, manager.Options{Namespace: namespace})
if err != nil {
Expand Down
8 changes: 0 additions & 8 deletions deploy/advanced/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ spec:
command:
- aws-secret-operator
imagePullPolicy: Always
readinessProbe:
exec:
command:
- stat
- /tmp/operator-sdk-ready
initialDelaySeconds: 4
periodSeconds: 10
failureThreshold: 1
env:
- name: WATCH_NAMESPACE
value: ""
Expand Down
8 changes: 0 additions & 8 deletions deploy/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ spec:
command:
- aws-secret-operator
imagePullPolicy: Always
readinessProbe:
exec:
command:
- stat
- /tmp/operator-sdk-ready
initialDelaySeconds: 4
periodSeconds: 10
failureThreshold: 1
env:
- name: WATCH_NAMESPACE
valueFrom:
Expand Down