Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: bump smol_str dependency to 0.1.17 #270

Merged
merged 1 commit into from
Sep 20, 2020
Merged

improvement: bump smol_str dependency to 0.1.17 #270

merged 1 commit into from
Sep 20, 2020

Conversation

sinato
Copy link
Contributor

@sinato sinato commented Sep 20, 2020 •
edited
Loading

This PR bumps the version of smol_str.

new_inline_from_ascii has been deprecated by the following commit.
rust-analyzer/smol_str@c30083d

Wodann
Wodann requested changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. I have one request, then it's ready to merge: is the check_log.txt a remnant from your testing? If so, can you remove it?

@Wodann Wodann added the type: perf Changes that improve performance label Sep 20, 2020
@codecov
Copy link

codecov bot commented Sep 20, 2020 •
edited
Loading

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         214      214           
  Lines       12808    12808           
=======================================
  Hits        10125    10125           
  Misses       2683     2683
Impacted Files Coverage Δ
crates/mun_hir/src/name.rs 70.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04821da...6b6a36e. Read the comment docs.

@sinato
Copy link
Contributor Author

sinato commented Sep 20, 2020

Oh sorry, I forgot to delete it.

@Wodann Wodann merged commit 6887b73 into mun-lang:master Sep 20, 2020
@sinato sinato deleted the update/smol_str branch September 20, 2020 12:10
@Wodann Wodann added this to the Mun v0.3.0 milestone Sep 20, 2020
@Wodann Wodann added type: build Changes that affect the build system or external dependencies and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@sinato sinato

Labels
type: build Changes that affect the build system or external dependencies
Projects
None yet
Milestone
Mun v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sinato @Wodann