-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parsing & hir of impl blocks #551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 87.37% 87.42% +0.05%
==========================================
Files 271 276 +5
Lines 31309 31970 +661
==========================================
+ Hits 27357 27951 +594
- Misses 3952 4019 +67 ☔ View full report in Codecov by Sentry. |
Wodann
reviewed
Dec 31, 2023
Wodann
approved these changes
Jan 7, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to support
impl
blocks for structs. Features included in this PR are:impl
blocks. (ast::Impl
and friends)impl
blocks inItemTree
.impl
impl
s from a package, or for a specific (struct) type.impl
blocks. (See tests inmethod_resolution.rs
)Impl
code model to interact with impl blocksNotable features that are still missing and will be addressed in followup PRs:
self
type.