Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only create symbols for public functions #92

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Mar 1, 2020

No description provided.

@Wodann Wodann requested a review from baszalmstra March 1, 2020 14:48
@Wodann Wodann self-assigned this Mar 1, 2020
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #92 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   76.84%   76.82%   -0.02%     
==========================================
  Files         122      122              
  Lines        9833     9601     -232     
==========================================
- Hits         7556     7376     -180     
+ Misses       2277     2225      -52
Impacted Files Coverage Δ
crates/mun_runtime_capi/src/tests.rs 99.47% <ø> (ø) ⬆️
crates/mun_runtime/src/test.rs 96.95% <ø> (-0.02%) ⬇️
crates/mun_codegen/src/code_gen/symbols.rs 96.53% <100%> (-0.67%) ⬇️
crates/mun_hir/src/adt.rs 89.28% <0%> (-5.55%) ⬇️
crates/mun_codegen/src/ir/function.rs 89.47% <0%> (-2.84%) ⬇️
crates/mun_runtime/src/assembly/temp_library.rs 70% <0%> (-2.73%) ⬇️
crates/mun_syntax/src/parsing/parser.rs 82.45% <0%> (-2.21%) ⬇️
crates/mun_runtime/src/macros.rs 72.22% <0%> (-1.47%) ⬇️
crates/mun_hir/src/resolve.rs 70.58% <0%> (-1.11%) ⬇️
crates/mun_hir/src/arena.rs 74.07% <0%> (-0.93%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78cbcde...ad72958. Read the comment docs.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I really think that at some point we have to refactor symbol generation. Its quite messy and unclear.

crates/mun_codegen/src/code_gen/symbols.rs Outdated Show resolved Hide resolved
@Wodann Wodann force-pushed the feature/fn-visibility branch from e74595e to ceccb4e Compare March 2, 2020 16:00
@Wodann Wodann force-pushed the feature/fn-visibility branch from ceccb4e to ad72958 Compare March 2, 2020 20:21
@Wodann Wodann merged commit 1ce4626 into mun-lang:master Mar 2, 2020
@Wodann
Copy link
Collaborator Author

Wodann commented Mar 7, 2020

@Wodann Wodann deleted the feature/fn-visibility branch March 25, 2020 11:25
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants