fix(logging): minor modifications for logging (datahub-project#11703)

murdo-moj · Oct 24, 2024 · ffefb9d · ffefb9d
1 parent 7c8dba4
commit ffefb9d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/li-utils/src/main/java/com/linkedin/metadata/Constants.java b/li-utils/src/main/java/com/linkedin/metadata/Constants.java
@@ -460,7 +460,7 @@ public class Constants {
 
   // Logging MDC
   public static final String MDC_ENTITY_URN = "entityUrn";
-  public static final String MDC_ASPECT_NAME = "";
+  public static final String MDC_ASPECT_NAME = "aspectName";
   public static final String MDC_ENTITY_TYPE = "entityType";
   public static final String MDC_CHANGE_TYPE = "changeType";
 

diff --git a/metadata-io/src/main/java/com/linkedin/metadata/service/UpdateGraphIndicesService.java b/metadata-io/src/main/java/com/linkedin/metadata/service/UpdateGraphIndicesService.java
@@ -388,24 +388,24 @@ private void updateGraphServiceDiff(
     // Remove any old edges that no longer exist first
     if (!subtractiveDifference.isEmpty()) {
       log.debug("Removing edges: {}", subtractiveDifference);
+      subtractiveDifference.forEach(graphService::removeEdge);
       MetricUtils.counter(this.getClass(), GRAPH_DIFF_MODE_REMOVE_METRIC)
           .inc(subtractiveDifference.size());
-      subtractiveDifference.forEach(graphService::removeEdge);
     }
 
     // Then add new edges
     if (!additiveDifference.isEmpty()) {
       log.debug("Adding edges: {}", additiveDifference);
+      additiveDifference.forEach(graphService::addEdge);
       MetricUtils.counter(this.getClass(), GRAPH_DIFF_MODE_ADD_METRIC)
           .inc(additiveDifference.size());
-      additiveDifference.forEach(graphService::addEdge);
     }
 
     // Then update existing edges
     if (!mergedEdges.isEmpty()) {
       log.debug("Updating edges: {}", mergedEdges);
-      MetricUtils.counter(this.getClass(), GRAPH_DIFF_MODE_UPDATE_METRIC).inc(mergedEdges.size());
       mergedEdges.forEach(graphService::upsertEdge);
+      MetricUtils.counter(this.getClass(), GRAPH_DIFF_MODE_UPDATE_METRIC).inc(mergedEdges.size());
     }
   }