Added RehearsalMark to midi export as Markers

[heavy-matill]

Resolves: Add Marker meta events to MIDI export and Exporting Rehearsal Markers to MIDI files

I want to export Rehearsal Marks to Midi Markers.
I export my sheetmusic as midi into a DAW, where Midi meta events such as Markers are supported.
Usually the sheetmusic contains Rehearsal Marks and I want the same structure to appear in my DAW.

This PR only adds export functionality. Import of Midi Markers to Rehearsal Marks is still missing.

I did not unit test the implementation but it works for the few examples I have on my machine.
I was also able to check it with python:

from miditoolkit import MidiFile
midFile = r"path\to\midi.mid"
midi_obj = MidiFile(midFile)

print(midi_obj)

ticks per beat: 480
max tick: 226561
tempo changes: 1
time sig: 1
key sig: 13
markers: 182
lyrics: True
instruments: 13

print(midi_obj.markers)

[Marker(text="A", time=7680), Marker(text="B", time=53760), ...

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[heavy-matill]

Regarding the Codestyle check:

In installed uncrustify on my windows machine and ran it in git bash. However other than complaining about an outdated configuration it did not throw any erros for the mentioned file.

> tools/codestyle/uncrustify_run_file.sh  src/importexport/midi/internal/midiexport/exportmidi.cpp
Option<NUM>: at tools/codestyle/uncrustify_musescore.cfg:209: Expected number , for 'indent_comma_paren'; got 'false'
Option<NUM>: at tools/codestyle/uncrustify_musescore.cfg:212: Expected number , for 'indent_bool_paren'; got 'false'
tools/codestyle/uncrustify_musescore.cfg:296: option 'sp_balance_nested_parens' never works; it has been replaced by 'sp_paren_paren'.

tools/codestyle/uncrustify_musescore.cfg:720: option 'sp_before_tr_emb_cmt' is deprecated; did you want to use 'sp_before_tr_cmt' instead?

tools/codestyle/uncrustify_musescore.cfg:723: option 'sp_num_before_tr_emb_cmt' is deprecated; did you want to use 'sp_num_before_tr_cmt' instead?

Option<UNUM>: at tools/codestyle/uncrustify_musescore.cfg:873: Expected unsigned number , for 'align_nl_cont'; got 'false'
tools/codestyle/uncrustify_musescore.cfg:950: option 'nl_func_var_def_blk' is deprecated; it has been replaced by 'nl_var_def_blk_end_func_top'.
You can also use 'nl_var_def_blk_end' for additional functionality.

Option<UNUM>: at tools/codestyle/uncrustify_musescore.cfg:1410: Expected unsigned number , for 'mod_full_brace_if_chain'; got 'false'
tools/codestyle/uncrustify_musescore.cfg:1560: option 'pp_space' is deprecated; it has been replaced by 'pp_space_after'.

do_source_file: Parsing: src/importexport/midi/internal/midiexport/exportmidi.cpp as language CPP

EDIT: had to install 0.73 of uncrustify via choco install uncrustify --version=0.73

[cbjeukendrup]

The problem is that you need specifically version 0.73 of Uncrustify. (We decided to pin the version at some point, because every Uncrustify update required changes to the code, which was quite inconvenient in combination with the fact that updates are rolled out gradually over GitHub Actions runners, so you never know in advance whether you're going to get a the new or old version.)

[Jojo-Schmitz]

Don't use merge commits, but rebase (and force push):
git pull --rebase upstream master; git push --force

[heavy-matill]

Don't use merge commits, but rebase (and force push): git pull --rebase upstream master; git push --force

Sorry, my vscode git integration keeps doing those in the background. I believe I have removed most of the unnecessary merge commits

[cbjeukendrup]

Thanks for this! Only two last minor requests, but apart from that it looks good. Also, after addressing these comments, it would be great if you could squash the commits, so that all changes are in one commit (with an appropriate message of course).

[cbjeukendrup]

(Just for the record: beware that there's a data leak here. But you don't need to fix it in this PR, because it's exactly the same for lyrics and port changes.)

[heavy-matill]

if the problem is tracked elsewhere i'd like to make a note there rather than a code comment now

[cbjeukendrup]

I'll open a tech debt issue about it, so you don't need to do anything with it now. (Update: created #26415)

[cbjeukendrup]

nitpick: alphabetical order is preferred :)

[cbjeukendrup]

Thanks! I can do the squashing while merging the PR, if it turns out to be difficult.

[bkunda]

@heavy-matill thanks for this initiative! It's a neat idea to be able to import rehearsal marks as markers to a DAW.

I just tried exporting a MIDI file from this PR and importing into Logic Pro, and unfortunately no markers appeared.

What DAWs have you tested this in so far?

[heavy-matill]

Thanks! I can do the squashing while merging the PR, if it turns out to be difficult.

Yes please do that. Somehow there is always a merge commit additionally to my squashed commit.

What DAWs have you tested this in so far?

It worked with Cubase 13 and 14 Trial.
It did not work with Cakewalk.

[Jojo-Schmitz]

The trick is not to rebase ;-) Use git pull --rebase upstream master, git push --force
As I said here 2 weeks ago...
That won't squash though

[cbjeukendrup]

Well, not to pull from origin. Only pull from upstream, then do the squashing, then don't pull from origin, but force-push to origin.

[cbjeukendrup]

I've fixed it now; because of the repeated merge commits, it had become a bit difficult to fix the situation if you don't feel comfortable with rebasing.

For the future, once more, the general flow is:

• For simply updating a PR with the latest changes from master:

  git pull --rebase upstream master
  git push -f

• For amending the last commit (i.e. making a small fix to the last commit):

  git add . # or whatever files you want to commit
  git commit --amend
  git push -f

And for squashing commits, you just do what you apparently already did, but after that, just force-push (git push -f).