Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make it minimally accessible by tab #757

Merged

Conversation

felipetoffolo1
Copy link
Contributor

Add minimal usability and accessibility using tabs

What did I do:

  • Removed some button elements that were buttons but were doing nothing useful but were acessible using tab
  • Change bottom navigation from tabs to buttons
  • Re-ordered DOM so that we would tab into the menu first
  • Stopped rendering the players select list when it was not opened (it was accessible using tab)

Next step:

  • Many things but we would have to take component by component I think
Screen.Recording.2024-11-29.at.14.47.06.mov

@felipetoffolo1 felipetoffolo1 changed the title chore: Make it minimally acessible by tab chore: Make it minimally accessible by tab Nov 29, 2024
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcelveldt marcelveldt merged commit e69b5bb into music-assistant:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants