Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Radio mode enhancements #1654

Merged
merged 16 commits into from
Sep 11, 2024
Merged

Feature: Radio mode enhancements #1654

merged 16 commits into from
Sep 11, 2024

Conversation

MarvinSchenkel
Copy link
Contributor

This PR implements the radio mode enhancements according to https://github.com/orgs/music-assistant/projects/2?pane=issue&itemId=70609106

@MarvinSchenkel MarvinSchenkel marked this pull request as ready for review September 11, 2024 14:14
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Nice work!

@marcelveldt marcelveldt merged commit a0abddc into main Sep 11, 2024
7 checks passed
@marcelveldt marcelveldt deleted the radio_enhancements branch September 11, 2024 21:03
@OzGav
Copy link
Contributor

OzGav commented Sep 11, 2024

@MarvinSchenkel is there an option or does it automatically switch to radio mode at the end of the queue per https://github.com/orgs/music-assistant/discussions/813 and the note at the end of that feature request from JLo?

@MarvinSchenkel
Copy link
Contributor Author

@MarvinSchenkel is there an option or does it automatically switch to radio mode at the end of the queue per https://github.com/orgs/music-assistant/discussions/813 and the note at the end of that feature request from JLo?

Not yet. First wanted to align the radio function. The "don't stop the music feature" will be added in a separate PR.

@OzGav
Copy link
Contributor

OzGav commented Sep 12, 2024

@MarvinSchenkel Did you see the ERROR I posted about on Discord?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants