fix: Subsonic: Fix album art missing from playlist display #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khers
force-pushed
the
feat-work
branch
3 times, most recently
from
70e226a to
8685d2d
Compare
In order to display album art in the playlist view, we need to have an album associated with each track. Mappings do not seem to be sufficient here. Allow any caller of _parse_track() to optionally provide an Album that should be used for this track and ensure that the playlist display queries that album and uses it. Fixes: https://github.com/music-assistant/hass-music-assistant/issues/3215 Signed-off-by: Eric B Munson <[email protected]>
marcelveldt
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to display album art in the playlist view, we need to have an album associated with each track. Mappings do not seem to be sufficient here. Allow any caller of _parse_track() to optionally provide an Album that should be used for this track and ensure that the playlist display queries that album and uses it.
Fixes: https://github.com/music-assistant/hass-music-assistant/issues/3215