Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsonic: Add Podcast Support #1802

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Conversation

khers
Copy link
Contributor

@khers khers commented Dec 3, 2024

This is a draft of the PR to add podcast support to the provider. I cannot test this yet as it seems the db tables are not ready.

I do want to call out the changes I had to make to the MusicProvider.

@khers khers force-pushed the podcasts branch 2 times, most recently from be03348 to cef0969 Compare December 4, 2024 02:21
@khers
Copy link
Contributor Author

khers commented Dec 4, 2024

With these patches, I can sync the podcasts on my gonic server (I see them in the logs) however I don't see anywhere in the UI for them, not sure that has been implemented yet.

@khers khers force-pushed the podcasts branch 2 times, most recently from b716836 to 00c9d27 Compare December 4, 2024 13:23
These methods were referring to Audio Book objects.

Signed-off-by: Eric B Munson <[email protected]>
The Podcast media type expects this column in the db, but the schema is
missing it. Add it and make sure the migration code adds it as well.

Signed-off-by: Eric B Munson <[email protected]>
Now that we have models for Podcasts, add that support to the subsonic
provider.

Signed-off-by: Eric B Munson <[email protected]>
@marcelveldt marcelveldt marked this pull request as ready for review December 26, 2024 13:00
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
FYI: I'm adding the UI support now so this should be in the next beta

@marcelveldt marcelveldt merged commit 73b5a7e into music-assistant:dev Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants