Fix: Correct maxsize of MetadataLookupQueue
#1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Small nit, could you please include the explanation for why this fixes the bug for you from your issue in the commit log here? |
Setting a default in the `_init_` hook is ineffective because the `asyncio.Queue.__init__` always passes in a concrete value. Since that constructor itself sets a default of zero this is what is used unless we pass in a size at construction time. Fixes https://github.com/music-assistant/hass-music-assistant/issues/3230.
ijc
force-pushed
the
metadataqueue-maxlen
branch
from
001ff30 to
9856f6e
Compare
|
Done. |
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/music-assistant/hass-music-assistant/issues/3230