Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error on filereader fails #136

Merged

Conversation

cjpillsbury
Copy link
Contributor

This is primarily to account for Safari/WebKit + Big Boi File errors (https://bugs.webkit.org/show_bug.cgi?id=272600)

  • Update our file Iterator to have an error state on failures of file read.
  • Handle this case like other errors in Upchunk.

relates to: #134

@cjpillsbury cjpillsbury requested a review from a team as a code owner April 18, 2024 20:54
@cjpillsbury cjpillsbury changed the title Feat/error on filereader fails feat: error on filereader fails Apr 18, 2024
@cjpillsbury cjpillsbury force-pushed the feat/error-on-filereader-fails branch from 380c32a to e6c75a3 Compare April 18, 2024 20:58
@cjpillsbury cjpillsbury merged commit dc93b1d into muxinc:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants