Keep narwhals when testing polars!

mwouts · Dec 15, 2024 · ae00927 · ae00927
1 parent 6250fff
commit ae00927
Showing 1 changed file with 13 additions and 17 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -41,10 +41,7 @@ jobs:
       ${{ matrix.python-version }}
       ${{ matrix.pandas-version && format('(pandas {0})', matrix.pandas-version)}}
       ${{ matrix.numpy-version && format('(numpy {0})', matrix.numpy-version)}}
-      ${{ matrix.polars && '(polars)' }}
-      ${{ matrix.modin && '(modin)' }}
-      ${{ matrix.uninstall_narwhals && '(without narwhals)' }}
-      ${{ matrix.uninstall_jinja2 && '(without jinja2)' }}
+      ${{ matrix.modifiers}}
     strategy:
       fail-fast: false
       matrix:
@@ -58,16 +55,15 @@ jobs:
             numpy-version: '<2.0'
           - python-version: "3.13"
             pandas-version: pre
-          - python-version: "3.13"
-            polars: true
           - python-version: "3.12"
-            modin: false
           - python-version: "3.12"
-            modin: true
+            modifiers: "modin"
+          - python-version: "3.13"
+            modifiers: "polars"
           - python-version: "3.13"
-            uninstall_narwhals: true
+            modifiers: "uninstall_narwhals"
           - python-version: "3.13"
-            uninstall_jinja2: true
+            modifiers: "uninstall_jinja2"
     runs-on: ubuntu-20.04
     steps:
       - name: Checkout
@@ -98,24 +94,24 @@ jobs:
         run: pip install 'numpy${{ matrix.numpy-version }}'
 
       - name: Install polars
-        if: matrix.polars
+        if: matrix.modifiers == 'polars'
         run: pip install polars
 
       - name: Install modin
-        if: matrix.modin
+        if: matrix.modifiers == 'modin'
         run: pip install modin[all]
 
       - name: Uninstall narwhals
-        if: matrix.uninstall_narwhals
+        if: matrix.modifiers == 'uninstall_narwhals'
         run: pip uninstall narwhals -y
 
-      - name: Install shiny
-        run: pip install "shiny>=1.0"
-
       - name: Uninstall jinja2
-        if: matrix.uninstall_jinja2
+        if: matrix.modifiers == 'uninstall_jinja2'
         run: pip uninstall jinja2 -y
 
+      - name: Install shiny
+        run: pip install "shiny>=1.0"
+
       - name: Install a Jupyter Kernel
         run: python -m ipykernel install --name itables --user