Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version numbering for text-only notebook formats #36

Closed
mwouts opened this issue Aug 22, 2018 · 1 comment
Closed

Version numbering for text-only notebook formats #36

mwouts opened this issue Aug 22, 2018 · 1 comment

Comments

@mwouts
Copy link
Owner

mwouts commented Aug 22, 2018

Text only notebook formats have a priority over ipynb notebooks. This may cause users to have their notebooks changed due to a file format update in nbrmd.

When both py and ipynb files are present, nbrmd should refuse to load py files that were not generated with the current version format, and instead, invite the reader to remove the py file (and get it regenerated in the new version, from the ipynb file).

mwouts added a commit that referenced this issue Aug 22, 2018
@mwouts
Copy link
Owner Author

mwouts commented Aug 22, 2018

The commit reference above will refuse to open a notebook from a pair of py, ipynb file when the py file has a version other than the current version, and display a message like this one

File Untitled1.py has nbrmd_file_format_version=None, but current version for that extension is 1.0. It would not be safe to override the source of Untitled1.ipynb with that file. Please remove one or the other file.

@mwouts mwouts mentioned this issue Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant