-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support language without line comment #827
Comments
Hi @fortierq , thanks for raising this. Well, this line comment character is just used to comment out magic commands, which I guess are not so frequent in OCaml notebooks ? Anyway I think it should be rather easy to handle this specificity of OCaml. I think we would just have to modify the functions Would you like to update your notebook so that it includes a magic command? Also I think we should define the |
Hi @mwouts, thanks for your answer. I don't plan to use magic commands and it is probably not used much indeed. |
Yes, you're right. Do you think that using block comments on every line would be acceptable? Also, for the markdown cells we have another option, which is to use multi-line strings - is it legal in OCaml to have multi line strings (and how do they look like)? Thanks! |
TODO: use block comment instead of line comment
* Add support for ml (#827, WIP) TODO: use block comment instead of line comment * Add block comments and ocaml support (#827) * Remove the version information from the mirror notebooks * Remove the comment suffix in uncomment/when parsing the header * More OCaml-specific tests * Update CHANGELOG.md Co-authored-by: Quentin Fortier <[email protected]>
I would like to add a language (OCaml) which has only block comments, and no line comments.
However, _SCRIPT_EXTENSIONS expects line comments.
Is it easy to add support for block comments? Or should I give up?
This is what I did so far: https://github.com/fortierq/jupytext/commit/b85303bbcf689ff8be299aff4e8cd9489326d367
The text was updated successfully, but these errors were encountered: