Add block comments and OCaml support #827 #832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: use block comment instead of line comment
|
Hi @fortierq , thank you for your PR. Sorry I was off for a while, now I am back and I'll have a look very soon |
|
Hi @fortierq , the PR looks great! I think the only thing left that you need to address is to take the Also I see that you've not used the pre-commit framework, maybe that page can be helpful https://jupytext.readthedocs.io/en/latest/developing.html (if you prefer not to use it that's not a problem, I can fix the files later on) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add one block comment for each line, and an optional comment_suffix in _SCRIPT_EXTENSIONS to end a comment block.
Since OCaml comments use *, I think that I need to escape it for regular expressions.
I get pytest errors with mirror files, but the files seem ok to me.