Restore the codecov comments on PRs #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 96.69% 97.59% +0.89%
==========================================
Files 26 26
Lines 4357 4357
==========================================
+ Hits 4213 4252 +39
+ Misses 144 105 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Because otherwise the commit always get a red cross
mwouts
force-pushed
the
codecov_comment
branch
from
c7f83ca to
b05b0b8
Compare
LecrisUT
reviewed
Nov 26, 2023
|
|
||
| - name: Upload coverage | ||
| uses: codecov/codecov-action@v3 | ||
| with: | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
fail_ci_if_error has no effect here because this step is not triggered if the test step failed. You can add if: always() if you do want it to upload failed code coverage.
| matrix: | ||
| python-version: [ "3.8", "3.9", "3.10", "3.11" ] | ||
| markdown-it-py-version: ["~=2.0"] | ||
| python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12-dev"] |
There was a problem hiding this comment.
Python 3.12 has been officially out. Should be included soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to close #1171 and #1172