Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close issue #587 properly escape shell iPython magic that begins with special characters. #588

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

Skylion007
Copy link
Contributor

This solves the issue of trying to run an executable script in the current directory, reference an absolute path to an executable or reference an environmental variable with iPython magic.

Previously, '!' iPython magic was not properly commented / uncommented for more complex Bash iPython magic constructions.

I've added tests to cover these more complex changes and modified the appropriate regex to handle the most common special characters.

Fixes #587

@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2020

This pull request introduces 2 alerts when merging e6caf08 into 213acee - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

@Skylion007
Copy link
Contributor Author

@mwouts the lgtm alert is outside of the code I edited in my PR

@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2020

This pull request introduces 2 alerts when merging 57c0a69 into 213acee - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

@mwouts
Copy link
Owner

mwouts commented Aug 20, 2020

Awesome! Thank you @Skylion007.
Indeed the issue raised by LGTM is not related to your contribution.
Let me see if I can fix that one first at #589 - I'll come back here afterwards.

@mwouts mwouts merged commit fd5b003 into mwouts:master Aug 20, 2020
@Skylion007 Skylion007 deleted the fix_executable_scripts branch August 21, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black has syntax error with valid iPython magic when using --pipe
2 participants