Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the unexpected warning in tests, if any #865

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Display the unexpected warning in tests, if any #865

merged 2 commits into from
Oct 6, 2021

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Oct 6, 2021

This will help getting more information on the CI failure at #864

@mwouts
Copy link
Owner Author

mwouts commented Oct 6, 2021

In the Python environment constructed with pip we get this warning:

Passing a schema to Validator.iter_errors is deprecated and will be removed in a future release. Call validator.evolve(schema=new_schema).iter_errors(...) instead.

The warning seems to be directly caused by nbformat/validator.py:311.

I'll change the tests to temporary ignore the warning.

@mwouts mwouts changed the title Raise on the first unexpected warning Display the unexpected warning in tests, if any Oct 6, 2021
@mwouts mwouts merged commit 8aa3d1f into main Oct 6, 2021
@mwouts mwouts deleted the display_unexpected_warnings_in_tests branch October 6, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mwouts