Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext refuses to open a non-unicode file (api, cli & jupyter) #897

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Dec 27, 2021

Fixes #896

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #897 (dc468aa) into main (f843c54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files         114      115    +1     
  Lines       10699    10721   +22     
=======================================
+ Hits        10597    10619   +22     
  Misses        102      102           
Impacted Files Coverage Δ
jupytext/contentsmanager.py 97.61% <100.00%> (ø)
jupytext/version.py 100.00% <100.00%> (ø)
tests/test_invalid_file.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f843c54...dc468aa. Read the comment docs.

@mwouts mwouts merged commit 703a729 into main Dec 27, 2021
@mwouts mwouts deleted the fail_on_unicode_error branch December 27, 2021 22:47
@drdarshan
Copy link

Thank you for the quick fix @mwouts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown text with accents produces invalid IPYNB file
2 participants